Conversation
Summary: Vendor `whatwg-fetch` v3.6.20 directly into `Libraries/Network/`, replacing the npm dependency with a local copy. `whatwg-fetch` has not had a release since December 2023 and appears to be [unmaintained](JakeChampion/fetch#1482), by download numbers `react-native` is the dominant consumer (all this is unsurprising, since `fetch` is natively implemented in every browser). It has several shortcomings we (with the OSS community) could improve on - one important one being that `whatwg-fetch`'s `fetch()` does not resolve immediately on receipt of headers, only on completion. This takes the single source file from the `whatwg-fetch` npm package as `Libraries/Network/whatwg-fetch.js`, and its accompanying types, marking as originally vendored from whatwg-fetch v3.6.20 (Copyright (c) 2014-2023 GitHub, Inc., MIT license). Changelog: [Internal] Reviewed By: huntie Differential Revision: D99854694
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in e7df8fa. |
Collaborator
|
This pull request was successfully merged by @robhogan in e7df8fa When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Vendor
whatwg-fetchv3.6.20 directly intoLibraries/Network/, replacing the npm dependency with a local copy.whatwg-fetchhas not had a release since December 2023 and appears to be unmaintained, by download numbersreact-nativeis the dominant consumer (all this is unsurprising, sincefetchis natively implemented in every browser).It has several shortcomings we (with the OSS community) could improve on - one important one being that
whatwg-fetch'sfetch()does not resolve immediately on receipt of headers, only on completion.This takes the single source file from the
whatwg-fetchnpm package asLibraries/Network/whatwg-fetch.js, and its accompanying types, marking as originally vendored from whatwg-fetch v3.6.20 (Copyright (c) 2014-2023 GitHub, Inc., MIT license).Changelog:
[Internal]
Reviewed By: huntie
Differential Revision: D99854694